Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QI2-663] Make devcontainer work with ARM #103

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

oschusler
Copy link
Contributor

No description provided.

@oschusler oschusler requested a review from koffie October 27, 2023 12:07
@oschusler oschusler self-assigned this Oct 27, 2023
Copy link
Contributor

@koffie koffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you just need to fix the unittest that checks what the settings look like.

@oschusler oschusler requested a review from koffie October 29, 2023 17:49
@oschusler oschusler force-pushed the feature/QI2-663/fix-devcontainer branch from 7890ce9 to be444ff Compare October 29, 2023 17:49
@oschusler oschusler merged commit f5b956e into dev Oct 30, 2023
14 checks passed
@oschusler oschusler deleted the feature/QI2-663/fix-devcontainer branch October 30, 2023 10:43
eliasKA pushed a commit that referenced this pull request May 30, 2024
* [QI2-663] Make devcontainer work with ARM

* [QI2-663] Address review comment

* [QI2-663] Fix unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants